net: xfrm: fix memory leak in xfrm_user_rcv_msg
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 25 Jun 2021 10:23:54 +0000 (13:23 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Aug 2021 11:22:01 +0000 (13:22 +0200)
commitd61dc8c634bb38bac8d68007e6d3cb938a8038f3
tree7b3301b5a233851e8bafc3f767d09242a5116a7b
parent8efe3a635f22de4a1b8d8affc95f8604251d402a
net: xfrm: fix memory leak in xfrm_user_rcv_msg

[ Upstream commit 7c1a80e80cde008f271bae630d28cf684351e807 ]

Syzbot reported memory leak in xfrm_user_rcv_msg(). The
problem was is non-freed skb's frag_list.

In skb_release_all() skb_release_data() will be called only
in case of skb->head != NULL, but netlink_skb_destructor()
sets head to NULL. So, allocated frag_list skb should be
freed manualy, since consume_skb() won't take care of it

Fixes: 5106f4a8acff ("xfrm/compat: Add 32=>64-bit messages translator")
Reported-and-tested-by: syzbot+fb347cf82c73a90efcca@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/xfrm/xfrm_user.c