smb/server: avoid deadlock when linking with ReplaceIfExists
authorNeilBrown <neil@brown.name>
Sun, 8 Jun 2025 23:35:09 +0000 (09:35 +1000)
committerSteve French <stfrench@microsoft.com>
Mon, 21 Jul 2025 00:17:14 +0000 (19:17 -0500)
commitd5fc1400a34b4ea5e8f2ce296ea12bf8c8421694
tree89ba55d2f9a24caff70d9b914b972a1f83527194
parenta5dc90a9c355a30300ea4b4b25f0732270568d83
smb/server: avoid deadlock when linking with ReplaceIfExists

If smb2_create_link() is called with ReplaceIfExists set and the name
does exist then a deadlock will happen.

ksmbd_vfs_kern_path_locked() will return with success and the parent
directory will be locked.  ksmbd_vfs_remove_file() will then remove the
file.  ksmbd_vfs_link() will then be called while the parent is still
locked.  It will try to lock the same parent and will deadlock.

This patch moves the ksmbd_vfs_kern_path_unlock() call to *before*
ksmbd_vfs_link() and then simplifies the code, removing the file_present
flag variable.

Signed-off-by: NeilBrown <neil@brown.name>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smb2pdu.c