dm integrity: fix double free on memory allocation failure
authorMikulas Patocka <mpatocka@redhat.com>
Mon, 3 Jul 2023 15:12:39 +0000 (17:12 +0200)
committerMike Snitzer <snitzer@kernel.org>
Tue, 25 Jul 2023 15:55:50 +0000 (11:55 -0400)
commitd4a3806bea61c8ef6e0103d0f39786e00586522e
tree2e91b285586b756330b1ac52c8fa44095f7fbf6a
parentfdf0eaf11452d72945af31804e2a1048ee1b574c
dm integrity: fix double free on memory allocation failure

If the statement "recalc_tags = kvmalloc(recalc_tags_size, GFP_NOIO);"
fails, we call "vfree(recalc_buffer)" and we jump to the label "oom".

If the condition "recalc_sectors >= 1U << ic->sb->log2_sectors_per_block"
is false, we jump to the label "free_ret" and call "vfree(recalc_buffer)"
again, on an already released memory block.

Fix the bug by setting "recalc_buffer = NULL" after freeing it.

Fixes: da8b4fc1f63a ("dm integrity: only allocate recalculate buffer when needed")
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-integrity.c