Input: ims-pcu - return error code rather than -ENOMEM
authorColin Ian King <colin.king@canonical.com>
Thu, 6 Aug 2020 22:34:07 +0000 (15:34 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 7 Aug 2020 00:33:40 +0000 (17:33 -0700)
commitd431b9e6af1903e112f5f773a0137be4fe5b17e8
tree7f58d486cf035c3e4a28f42f10c26e2e13845c65
parent873a3a14a47e819bb2d1e3cf4dc8c59c200ec32b
Input: ims-pcu - return error code rather than -ENOMEM

Currently the assignment of -ENOMEM to error is redundant because error
is not being read and -ENOMEM is being hard coded as an error return.
Fix this by returning the error code in variable 'error'; this also
allows the error code from a failed call to input_register_device to
be preserved and returned to the caller rather than just returning
a possibly inappropriate -ENOMEM.

Kudos to Dan Carpenter for the suggestion of an improved fix.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200603152151.139337-1-colin.king@canonical.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/ims-pcu.c