xen/xenbus: Add __counted_by for struct read_buffer and use struct_size()
authorGustavo A. R. Silva <gustavoars@kernel.org>
Mon, 9 Oct 2023 18:55:30 +0000 (12:55 -0600)
committerJuergen Gross <jgross@suse.com>
Mon, 16 Oct 2023 13:18:33 +0000 (15:18 +0200)
commitd3a2b6b48f726b5a06f7ce9b8aab84f3cfe6b0fb
tree8115b0e716583601c2e05be570d80a3e740c00dd
parent44961b81a9e9059b5c0443643915386db7035227
xen/xenbus: Add __counted_by for struct read_buffer and use struct_size()

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

While there, use struct_size() helper, instead of the open-coded
version, to calculate the size for the allocation of the whole
flexible structure, including of course, the flexible-array member.

This code was found with the help of Coccinelle, and audited and
fixed manually.

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Jason Andryuk <jandryuk@gmail.com>
Link: https://lore.kernel.org/r/ZSRMosLuJJS5Y/io@work
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/xen/xenbus/xenbus_dev_frontend.c