cxl/region: Convert cxl_pmem_region_alloc to scope-based resource management
authorDan Williams <dan.j.williams@intel.com>
Tue, 30 Apr 2024 21:59:00 +0000 (14:59 -0700)
committerDave Jiang <dave.jiang@intel.com>
Wed, 1 May 2024 16:17:04 +0000 (09:17 -0700)
commitd357dd8ad2f154376e5cb930284e7bf4fe21ffaa
treed64a661cbade494f2355fdb7f56e0c714c367fb6
parente4ff70a8e3352f71b5db52c752a9417402a098c8
cxl/region: Convert cxl_pmem_region_alloc to scope-based resource management

A recent bugfix to cxl_pmem_region_alloc() to fix an
error-unwind-memleak [1], highlighted a use case for scope-based resource
management.

Delete the goto for releasing @cxl_region_rwsem, and return error codes
directly from error condition paths.

The caller, devm_cxl_add_pmem_region(), is no longer given @cxlr_pmem
directly it must retrieve it from @cxlr->cxlr_pmem. This retrieval from
@cxlr was already in place for @cxlr->cxl_nvb, and converting
cxl_pmem_region_alloc() to return an int makes it less awkward to handle
no_free_ptr().

Cc: Li Zhijian <lizhijian@fujitsu.com>
Reported-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Closes: http://lore.kernel.org/r/20240430174540.000039ce@Huawei.com
Link: http://lore.kernel.org/r/20240428030748.318985-1-lizhijian@fujitsu.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/171451430965.1147997.15782562063090960666.stgit@dwillia2-xfh.jf.intel.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/region.c