net: amd: Fix link leak when verifying config failed
authorGencen Gan <gangecen@hust.edu.cn>
Mon, 24 Apr 2023 15:28:01 +0000 (23:28 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 25 Apr 2023 08:41:18 +0000 (09:41 +0100)
commitd325c34d9e7e38d371c0a299d415e9b07f66a1fb
treed63db238006d8d738433d538dbcb7de84a80fb6e
parentd913d32cc2707e9cd24fe6fa6d7d470e9c728980
net: amd: Fix link leak when verifying config failed

After failing to verify configuration, it returns directly without
releasing link, which may cause memory leak.

Paolo Abeni thinks that the whole code of this driver is quite
"suboptimal" and looks unmainatained since at least ~15y, so he
suggests that we could simply remove the whole driver, please
take it into consideration.

Simon Horman suggests that the fix label should be set to
"Linux-2.6.12-rc2" considering that the problem has existed
since the driver was introduced and the commit above doesn't
seem to exist in net/net-next.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Gan Gecen <gangecen@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/amd/nmclan_cs.c