scsi: libiscsi: Fix iscsi_prep_scsi_cmd_pdu() error handling
authorMike Christie <michael.christie@oracle.com>
Sun, 7 Feb 2021 04:46:00 +0000 (22:46 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 9 Feb 2021 03:39:03 +0000 (22:39 -0500)
commitd28d48c699779973ab9a3bd0e5acfa112bd4fdef
treee4b2b4e25960b83409ba78094acc29e34dc9dbc2
parent70ae13abd5d054d32a68a35a81fd4f37f88fc7e1
scsi: libiscsi: Fix iscsi_prep_scsi_cmd_pdu() error handling

If iscsi_prep_scsi_cmd_pdu() fails we try to add it back to the cmdqueue,
but we leave it partially setup. We don't have functions that can undo the
pdu and init task setup. We only have cleanup_task which can clean up both
parts. So this has us just fail the cmd and go through the standard cleanup
routine and then have the SCSI midlayer retry it like is done when it fails
in the queuecommand path.

Link: https://lore.kernel.org/r/20210207044608.27585-2-michael.christie@oracle.com
Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libiscsi.c