fs/fs_parse: Remove unused and problematic validate_constant_table()
authorZijun Hu <quic_zijuhu@quicinc.com>
Tue, 15 Apr 2025 12:25:00 +0000 (20:25 +0800)
committerChristian Brauner <brauner@kernel.org>
Mon, 21 Apr 2025 08:27:59 +0000 (10:27 +0200)
commitd1f482108a2cff2b9c6ebebc40b157aaeb8213b3
tree5a53a22ad69b74d6d12c2d446c2ac393e4ff1b1f
parent296b67059e3026125a1ca942f5506e6ca051749e
fs/fs_parse: Remove unused and problematic validate_constant_table()

Remove validate_constant_table() since:

- It has no caller.

- It has below 3 bugs for good constant table array array[] which must
  end with a empty entry, and take below invocation for explaination:
  validate_constant_table(array, ARRAY_SIZE(array), ...)

  - Always return wrong value due to the last empty entry.
  - Imprecise error message for missorted case.
  - Potential NULL pointer dereference since the last pr_err() may use
    @tbl[i].name NULL pointer to print the last empty entry's name.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/20250415-fix_fs-v4-1-5d575124a3ff@quicinc.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Documentation/filesystems/mount_api.rst
fs/fs_parser.c
include/linux/fs_parser.h