net: sxgbe: remove eee_enabled/eee_active in sxgbe_get_eee()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sun, 4 Feb 2024 12:13:07 +0000 (12:13 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 7 Feb 2024 17:03:37 +0000 (09:03 -0800)
commitd0d8c548789d45391c7c592fb763fab2fee0f632
tree5ed9b4caf869254f69dabd629b8893b85dbf96bf
parent0cb6daf549f99cc978fe4dd531d2426313fc08e4
net: sxgbe: remove eee_enabled/eee_active in sxgbe_get_eee()

sxgbe_get_eee() sets edata->eee_active and edata->eee_enabled from its
own copy, and then calls phy_ethtool_get_eee() which in turn will call
genphy_c45_ethtool_get_eee().

genphy_c45_ethtool_get_eee() will overwrite eee_enabled and eee_active
with its own interpretation from the PHYs settings and negotiation
result.

Therefore, setting these members in sxgbe_get_eee() is redundant.
Remove this, and remove the priv->eee_active member which then becomes
a write-only variable.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/E1rWbMx-002cCb-IU@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h
drivers/net/ethernet/samsung/sxgbe/sxgbe_ethtool.c
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c