PCI/ASPM: Ignore L1 PM Substates if device lacks capability
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 5 Oct 2022 02:58:08 +0000 (21:58 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 5 Oct 2022 17:11:56 +0000 (12:11 -0500)
commitcfc0028627cadfa271fab0290f18731193d63d87
tree538fcbf073e7c0919c2c81898c2b8836ee6ebfa9
parent9e2a03173d1b4544c1113059e61e3caa7ce5e3a4
PCI/ASPM: Ignore L1 PM Substates if device lacks capability

187f91db8237 ("PCI/ASPM: Remove struct aspm_register_info.l1ss_cap")
inadvertently removed a check for existence of the L1 PM Substates (L1SS)
Capability before reading it.

If there is no L1SS Capability, this means we mistakenly read PCI_COMMAND
and PCI_STATUS (config address 0x04) and interpret that as the PCI_L1SS_CAP
register, so we may incorrectly configure L1SS.

Make sure the L1SS Capability exists before trying to read it.

Fixes: 187f91db8237 ("PCI/ASPM: Remove struct aspm_register_info.l1ss_cap")
Link: https://lore.kernel.org/r/20221005025809.2247547-3-helgaas@kernel.org
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
drivers/pci/pcie/aspm.c