drm/i915/power: fix size for for_each_set_bit() in abox iteration
authorJani Nikula <jani.nikula@intel.com>
Fri, 5 Sep 2025 10:41:49 +0000 (13:41 +0300)
committerTvrtko Ursulin <tursulin@ursulin.net>
Tue, 9 Sep 2025 08:08:37 +0000 (09:08 +0100)
commitcfa7b7659757f8d0fc4914429efa90d0d2577dd7
treeb038dca1b85243391e9d687f8ba1d62ccccbeeea
parent76eeb9b8de9880ca38696b2fb56ac45ac0a25c6c
drm/i915/power: fix size for for_each_set_bit() in abox iteration

for_each_set_bit() expects size to be in bits, not bytes. The abox mask
iteration uses bytes, but it works by coincidence, because the local
variable holding the mask is unsigned long, and the mask only ever has
bit 2 as the highest bit. Using a smaller type could lead to subtle and
very hard to track bugs.

Fixes: 62afef2811e4 ("drm/i915/rkl: RKL uses ABOX0 for pixel transfers")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: stable@vger.kernel.org # v5.9+
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://lore.kernel.org/r/20250905104149.1144751-1-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
(cherry picked from commit 7ea3baa6efe4bb93d11e1c0e6528b1468d7debf6)
Signed-off-by: Tvrtko Ursulin <tursulin@ursulin.net>
drivers/gpu/drm/i915/display/intel_display_power.c