dmaengine: idxd: fix lockdep warning on device driver removal
authorDave Jiang <dave.jiang@intel.com>
Thu, 12 May 2022 00:00:44 +0000 (17:00 -0700)
committerVinod Koul <vkoul@kernel.org>
Mon, 16 May 2022 12:49:29 +0000 (18:19 +0530)
commitcf4ac3fef33883a14131d8925d7edfbdb7d69b68
treef8bb4bc652c9bb5faf24f584f8079fa6e6142b1d
parent42a1b73852c4a176d233a192422b5e1d0ba67cbf
dmaengine: idxd: fix lockdep warning on device driver removal

Jacob reported that with lockdep debug turned on, idxd_device_driver
removal causes kernel splat from lock assert warning for
idxd_device_wqs_clear_state(). Make sure
idxd_device_wqs_clear_state() holds the wq lock for each wq when
cleaning the wq state. Move the call outside of the device spinlock.

Reported-by: Jacob Pan <jacob.jun.pan@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/165231364426.986304.9294302800482492780.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/device.c