ila: block BH in ila_output()
authorEric Dumazet <edumazet@google.com>
Fri, 31 May 2024 13:26:35 +0000 (13:26 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 4 Jun 2024 01:50:09 +0000 (18:50 -0700)
commitcf28ff8e4c02e1ffa850755288ac954b6ff0db8c
tree89f3d6c9ecedbc77668983cdb86011501da72aa5
parentc0b98ac1cc104f48763cdb27b1e9ac25fd81fc90
ila: block BH in ila_output()

As explained in commit 1378817486d6 ("tipc: block BH
before using dst_cache"), net/core/dst_cache.c
helpers need to be called with BH disabled.

ila_output() is called from lwtunnel_output()
possibly from process context, and under rcu_read_lock().

We might be interrupted by a softirq, re-enter ila_output()
and corrupt dst_cache data structures.

Fix the race by using local_bh_disable().

Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Link: https://lore.kernel.org/r/20240531132636.2637995-5-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/ila/ila_lwt.c