Input: omap-keypad - prefer struct_size over open coded arithmetic
authorLen Baker <len.baker@gmx.com>
Sat, 11 Sep 2021 22:55:27 +0000 (15:55 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 21 Sep 2021 04:59:48 +0000 (21:59 -0700)
commitcef6f5cc140852fcb6c75f85b8e6ba00d7de1bad
treea9c564cd03f540b2a961a3176ee9ee8a3ada4939
parente2afe95a87a268bcdca2fb489d9c8a485e3aca85
Input: omap-keypad - prefer struct_size over open coded arithmetic

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the struct_size() helper to do the arithmetic instead of the
argument "size + count * size" in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
Link: https://lore.kernel.org/r/20210911112716.10067-1-len.baker@gmx.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/omap-keypad.c