ocfs2: fix possible memory leak in ocfs2_finish_quota_recovery
authorMurad Masimov <m.masimov@mt-integration.ru>
Wed, 2 Apr 2025 06:56:27 +0000 (09:56 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 12 May 2025 00:54:11 +0000 (17:54 -0700)
commitcdc3ed3035d0fe934aa1d9b78ce256752fd3bb7d
treede2218e9f3c16b84a4b6b95cd31da5e78f7c1e2c
parentd66adabe91803ef34a8b90613c81267b5ded1472
ocfs2: fix possible memory leak in ocfs2_finish_quota_recovery

If ocfs2_finish_quota_recovery() exits due to an error before passing all
rc_list elements to ocfs2_recover_local_quota_file() then it can lead to a
memory leak as rc_list may still contain elements that have to be freed.

Release all memory allocated by ocfs2_add_recovery_chunk() using
ocfs2_free_quota_recovery() instead of kfree().

Found by Linux Verification Center (linuxtesting.org) with Syzkaller.

Link: https://lkml.kernel.org/r/20250402065628.706359-2-m.masimov@mt-integration.ru
Fixes: 2205363dce74 ("ocfs2: Implement quota recovery")
Signed-off-by: Murad Masimov <m.masimov@mt-integration.ru>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Changwei Ge <gechangwei@live.cn>
Cc: Jun Piao <piaojun@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/ocfs2/quota_local.c