tracing/user_events: Ensure write index cannot be negative
authorBeau Belgrave <beaub@linux.microsoft.com>
Tue, 25 Apr 2023 22:51:04 +0000 (15:51 -0700)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Wed, 26 Apr 2023 01:03:46 +0000 (21:03 -0400)
commitcd98c93286a30cc4588dfd02453bec63c2f4acf4
tree7bb663ac6965bdb99ddacaace92b5f52aebfbe2f
parent96928d9032a7c34f12a88df879665562bcebf59a
tracing/user_events: Ensure write index cannot be negative

The write index indicates which event the data is for and accesses a
per-file array. The index is passed by user processes during write()
calls as the first 4 bytes. Ensure that it cannot be negative by
returning -EINVAL to prevent out of bounds accesses.

Update ftrace self-test to ensure this occurs properly.

Link: https://lkml.kernel.org/r/20230425225107.8525-2-beaub@linux.microsoft.com
Fixes: 7f5a08c79df3 ("user_events: Add minimal support for trace_event into ftrace")
Reported-by: Doug Cook <dcook@linux.microsoft.com>
Signed-off-by: Beau Belgrave <beaub@linux.microsoft.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events_user.c
tools/testing/selftests/user_events/ftrace_test.c