RDMA/mlx5: Fix a race for DMABUF MR which can lead to CQE with error
authorYishai Hadas <yishaih@nvidia.com>
Mon, 3 Feb 2025 12:50:59 +0000 (14:50 +0200)
committerLeon Romanovsky <leon@kernel.org>
Thu, 6 Feb 2025 08:43:34 +0000 (03:43 -0500)
commitcc668a11e6ac8adb0e016711080d3f314722cc91
tree2c28b8479ad899f0cbaec2cdae9cff038eeaa9fa
parent12d044770e12c4205fa69535b4fa8a9981fea98f
RDMA/mlx5: Fix a race for DMABUF MR which can lead to CQE with error

This patch addresses a potential race condition for a DMABUF MR that can
result in a CQE with an error on the UMR QP.

During the __mlx5_ib_dereg_mr() flow, the following sequence of calls
occurs:
mlx5_revoke_mr()
mlx5r_umr_revoke_mr()
mlx5r_umr_post_send_wait()
At this point, the lkey is freed from the hardware's perspective.

However, concurrently, mlx5_ib_dmabuf_invalidate_cb() might be triggered
by another task attempting to invalidate the MR having that freed lkey.

Since the lkey has already been freed, this can lead to a CQE error,
causing the UMR QP to enter an error state.

To resolve this race condition, the dma_resv_lock() which was hold as
part of the mlx5_ib_dmabuf_invalidate_cb() is now also acquired as part
of the mlx5_revoke_mr() scope.

Upon a successful revoke, we set umem_dmabuf->private which points to
that MR to NULL, preventing any further invalidation attempts on its
lkey.

Fixes: e6fb246ccafb ("RDMA/mlx5: Consolidate MR destruction to mlx5_ib_dereg_mr()")
Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
Reviewed-by: Artemy Kovalyov <artemyko@mnvidia.com>
Link: https://patch.msgid.link/70617067abbfaa0c816a2544c922e7f4346def58.1738587016.git.leon@kernel.org
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/mlx5/mr.c