ALSA: usx2y: fix a double free bug
authorWenwen Wang <wang6495@umn.edu>
Mon, 29 Apr 2019 17:45:40 +0000 (12:45 -0500)
committerTakashi Iwai <tiwai@suse.de>
Mon, 29 Apr 2019 17:56:41 +0000 (19:56 +0200)
commitcbb88db76a1536e02e93e5bd37ebbfbb6c4043a9
treedf45aeaa58f1d3638549c8812049764e73a4b7f0
parentb60ee2e281b6c67cbe0bb8412f3cae53903173c6
ALSA: usx2y: fix a double free bug

In usX2Y_In04_init(), a new urb is firstly created through usb_alloc_urb()
and saved to 'usX2Y->In04urb'. Then, a buffer is allocated through
kmalloc() and saved to 'usX2Y->In04Buf'. If the allocation of the buffer
fails, the error code ENOMEM is returned after usb_free_urb(), which frees
the created urb. However, the urb is actually freed at card->private_free
callback, i.e., snd_usX2Y_card_private_free(). So the free operation here
leads to a double free bug.

To fix the above issue, simply remove usb_free_urb().

Signed-off-by: Wenwen Wang <wang6495@umn.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/usx2y/usbusx2y.c