irqchip/riscv-imsic: Don't dereference before NULL pointer check
authorThomas Gleixner <tglx@linutronix.de>
Sat, 2 Aug 2025 10:59:13 +0000 (12:59 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 5 Aug 2025 08:29:24 +0000 (10:29 +0200)
commitcb9f6a40382ca7b7a81d6f52285f897b09b5851b
treefad34abab80873337fb4e786a4430c6cad5a6a28
parent7e161a991ea71e6ec526abc8f40c6852ebe3d946
irqchip/riscv-imsic: Don't dereference before NULL pointer check

smatch warns about a dereference before check:
drivers/irqchip/irq-riscv-imsic-platform.c:317 imsic_irqdomain_init() warn: variable dereferenced before check 'imsic' (see line 311)

Cure it by moving the firmware not assignement after the checks.

Fixes: 59422904dd98 ("irqchip/riscv-imsic: Convert to msi_create_parent_irq_domain() helper")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Closes: https://lore.kernel.org/r/202507311953.NFVZkr0a-lkp@intel.com/                                                                                                                                                                                                                                                       ---
 drivers/irqchip/irq-riscv-imsic-platform.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-riscv-imsic-platform.c