scsi: elx: efct: Fix is_originator return code type
authorJames Smart <jsmart2021@gmail.com>
Fri, 18 Jun 2021 23:15:24 +0000 (16:15 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 19 Jun 2021 03:01:04 +0000 (23:01 -0400)
commitca7f33c6b4a9b9893a5ba3aac57e7255510a4aac
tree140251bbff5d1c9c7603edfe0e43e5f1587662c2
parentd66a65b7f5d219528520e287ff53aea1b5252ec3
scsi: elx: efct: Fix is_originator return code type

efct_hw_iotype_is_originator() is returning a negative (-EIO) status which
doesn't make sense for a u8 function type.

Reviewing the code, the function only needs to return true/false, thus a
bool status is most appropriate.

Change the function return type and patch up the one callee as the bool
inverses the if check.

Link: https://lore.kernel.org/r/20210618231524.83179-1-jsmart2021@gmail.com
Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/elx/efct/efct_hw.c