drivers/perf: pmuv3: don't expose SW_INCR event in sysfs
authorMark Rutland <mark.rutland@arm.com>
Mon, 4 Dec 2023 11:58:47 +0000 (11:58 +0000)
committerWill Deacon <will@kernel.org>
Tue, 5 Dec 2023 12:34:24 +0000 (12:34 +0000)
commitca6f537e459e2da4b331fe8928d1a0b0f9301f42
tree0b3bfcf33c5f00f7b0255e265b26348508625a11
parent877806b9b41ea371defaaf58d815320f1a76384f
drivers/perf: pmuv3: don't expose SW_INCR event in sysfs

The SW_INCR event is somewhat unusual, and depends on the specific HW
counter that it is programmed into. When programmed into PMEVCNTR<n>,
SW_INCR will count any writes to PMSWINC_EL0 with bit n set, ignoring
writes to SW_INCR with bit n clear.

Event rotation means that there's no fixed relationship between
perf_events and HW counters, so this isn't all that useful.

Further, we program PMUSERENR.{SW,EN}=={0,0}, which causes EL0 writes to
PMSWINC_EL0 to be trapped and handled as UNDEFINED, resulting in a
SIGILL to userspace.

Given that, it's not a good idea to expose SW_INCR in sysfs. Hide it as
we did for CHAIN back in commit:

  4ba2578fa7b55701 ("arm64: perf: don't expose CHAIN event in sysfs")

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20231204115847.2993026-1-mark.rutland@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/perf/arm_pmuv3.c