nbd: fix race between timeout and normal completion
authorMing Lei <ming.lei@redhat.com>
Fri, 30 Aug 2024 03:41:45 +0000 (11:41 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 30 Aug 2024 20:46:59 +0000 (14:46 -0600)
commitc9ea57c91f03bcad415e1a20113bdb2077bcf990
tree5865f68b6cbf4a769432fbcda17dde2fd229ece2
parent12c612e115f3f021e72025447233ca89c94fb751
nbd: fix race between timeout and normal completion

If request timetout is handled by nbd_requeue_cmd(), normal completion
has to be stopped for avoiding to complete this requeued request, other
use-after-free can be triggered.

Fix the race by clearing NBD_CMD_INFLIGHT in nbd_requeue_cmd(), meantime
make sure that cmd->lock is grabbed for clearing the flag and the
requeue.

Cc: Josef Bacik <josef@toxicpanda.com>
Cc: Yu Kuai <yukuai3@huawei.com>
Fixes: 2895f1831e91 ("nbd: don't clear 'NBD_CMD_INFLIGHT' flag if request is not completed")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20240830034145.1827742-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/nbd.c