ipmi_si_intf: Fix race in timer shutdown handling
authorJes Sorensen <jsorensen@fb.com>
Wed, 28 Aug 2019 20:36:25 +0000 (16:36 -0400)
committerCorey Minyard <cminyard@mvista.com>
Thu, 12 Sep 2019 21:03:18 +0000 (16:03 -0500)
commitc9acc3c4f8e42ae538aea7f418fddc16f257ba75
tree8cd75733593157def2fe78aeadb37d21c5bb4c22
parent383035211c79d4d98481a09ad429b31c7dbf22bd
ipmi_si_intf: Fix race in timer shutdown handling

smi_mod_timer() enables the timer before setting timer_running. This
means the timer can be running when we get to stop_timer_and_thread()
without timer_running having been set, resulting in del_timer_sync()
not being called and the timer being left to cause havoc during
shutdown.

Instead just call del_timer_sync() unconditionally

Signed-off-by: Jes Sorensen <jsorensen@fb.com>
Message-Id: <20190828203625.32093-2-Jes.Sorensen@gmail.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_si_intf.c