srcu: Prevent cleanup_srcu_struct() from freeing non-dynamic ->sda
authorPaul E. McKenney <paulmck@kernel.org>
Thu, 27 Jan 2022 21:20:49 +0000 (13:20 -0800)
committerPaul E. McKenney <paulmck@kernel.org>
Tue, 8 Feb 2022 19:10:19 +0000 (11:10 -0800)
commitc93aba1b15be8baf3c02f1cd0366075f9b333acd
treeae29a3f9a236c2d82a0151ffc5f91ba89d3ebe83
parent7d897cbbdc1c8b2da59db20e2ab2760f00adee27
srcu: Prevent cleanup_srcu_struct() from freeing non-dynamic ->sda

When an srcu_struct structure is created (but not in a kernel module)
by DEFINE_SRCU() and friends, the per-CPU srcu_data structure is
statically allocated.  In all other cases, that structure is obtained
from alloc_percpu(), in which case cleanup_srcu_struct() must invoke
free_percpu() on the resulting ->sda pointer in the srcu_struct pointer.

Which it does.

Except that it also invokes free_percpu() on the ->sda pointer
referencing the statically allocated per-CPU srcu_data structures.
Which free_percpu() is surprisingly OK with.

This commit nevertheless stops cleanup_srcu_struct() from freeing
statically allocated per-CPU srcu_data structures.

Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
include/linux/srcutree.h
kernel/rcu/srcutree.c