crypto: ccree - Fix use after free in cc_cipher_exit()
authorJianglei Nie <niejianglei2021@163.com>
Thu, 3 Mar 2022 02:23:37 +0000 (10:23 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:40:02 +0000 (14:40 +0200)
commitc93017c8d5ebf55a4e453ac7c84cc84cf92ab570
tree080450c7e3e4a407183ced2ebd0fe3ed6437b0ea
parent78622926fe01363d78b0f861bfa5c35223c0a645
crypto: ccree - Fix use after free in cc_cipher_exit()

[ Upstream commit 3d950c34074ed74d2713c3856ba01264523289e6 ]

kfree_sensitive(ctx_p->user.key) will free the ctx_p->user.key. But
ctx_p->user.key is still used in the next line, which will lead to a
use after free.

We can call kfree_sensitive() after dev_dbg() to avoid the uaf.

Fixes: 63ee04c8b491 ("crypto: ccree - add skcipher support")
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/ccree/cc_cipher.c