nvme: skip optional id ctrl csi if it failed
authorKeith Busch <kbusch@kernel.org>
Tue, 30 May 2023 15:18:20 +0000 (08:18 -0700)
committerKeith Busch <kbusch@kernel.org>
Tue, 13 Jun 2023 01:24:15 +0000 (18:24 -0700)
commitc917dd96fe41c2fb2a4b606372bf64ec5661f509
tree58f8adbc68a0b0372e43d18b2496edb6c6c84ef6
parent35e797b0246b49d116326ff23c2dbfd6507168a5
nvme: skip optional id ctrl csi if it failed

A frequently recieved report is the driver requests the optional Command
Set Specific Identify Controller structure. Some controllers report this
in their error log, which tiggers other warnings to user space
monitoring the devices.

These error entries are harmless and of questionable value to save in
the log, but let's reduce their occurance by not resending the command
if it previously failed. This will not prevent the errors on the initial
module load, but will greatly reduce their occurance on any rescans and
resumes from suspend.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217445
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/core.c
drivers/nvme/host/nvme.h