netpoll: Use rcu_access_pointer() in __netpoll_setup
authorBreno Leitao <leitao@debian.org>
Mon, 18 Nov 2024 11:15:17 +0000 (03:15 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 19 Nov 2024 03:01:36 +0000 (19:01 -0800)
commitc69c5e10adb903ae2438d4f9c16eccf43d1fcbc1
tree140b123af80f627f6414393f259937b9f85ea135
parent4262bacb748fdab129dfbe1e93af75119a9c2775
netpoll: Use rcu_access_pointer() in __netpoll_setup

The ndev->npinfo pointer in __netpoll_setup() is RCU-protected but is being
accessed directly for a NULL check. While no RCU read lock is held in this
context, we should still use proper RCU primitives for consistency and
correctness.

Replace the direct NULL check with rcu_access_pointer(), which is the
appropriate primitive when only checking for NULL without dereferencing
the pointer. This function provides the necessary ordering guarantees
without requiring RCU read-side protection.

Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20241118-netpoll_rcu-v1-1-a1888dcb4a02@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/netpoll.c