iommu/amd: Enable PASID and ATS capabilities in the correct order
authorEaswar Hariharan <eahariha@linux.microsoft.com>
Thu, 3 Jul 2025 15:54:33 +0000 (08:54 -0700)
committerJoerg Roedel <joerg.roedel@amd.com>
Fri, 11 Jul 2025 07:13:58 +0000 (09:13 +0200)
commitc694bc8b612ddd0dd70e122a00f39cb1e2e6927f
tree5f2032e4af910a217e31633b0c3b581ae082f958
parent025d1371cc8c852ae1b3c2916cf7403902346350
iommu/amd: Enable PASID and ATS capabilities in the correct order

Per the PCIe spec, behavior of the PASID capability is undefined if the
value of the PASID Enable bit changes while the Enable bit of the
function's ATS control register is Set. Unfortunately,
pdev_enable_caps() does exactly that by ordering enabling ATS for the
device before enabling PASID.

Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: Vasant Hegde <vasant.hegde@amd.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: Jerry Snitselaar <jsnitsel@redhat.com>
Fixes: eda8c2860ab679 ("iommu/amd: Enable device ATS/PASID/PRI capabilities independently")
Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20250703155433.6221-1-eahariha@linux.microsoft.com
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
drivers/iommu/amd/iommu.c