crypto: hisilicon - cleanup warning in qm_get_qos_value()
authorTom Rix <trix@redhat.com>
Wed, 22 Dec 2021 17:29:23 +0000 (09:29 -0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 31 Dec 2021 07:10:56 +0000 (18:10 +1100)
commitc5d692a2335d64ac390aeb8ab6c4ac9f662e1be4
tree91952b302d5b7989fe118b1da7a91610c525b3d7
parent304b4acee2f023a67f122d15a37b40ce460244d9
crypto: hisilicon - cleanup warning in qm_get_qos_value()

Building with clang static analysis returns this warning:

qm.c:4382:11: warning: The left operand of '==' is a garbage value
        if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
            ~~~~ ^

The call to qm_qos_value_init() can return an error without setting
*val.  So check ret before checking *val.

Fixes: 72b010dc33b9 ("crypto: hisilicon/qm - supports writing QoS int the host")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/hisilicon/qm.c