selftests/bpf: test_verifier verbose causes erroneous failures
authorGregory Bell <grbell@redhat.com>
Mon, 12 May 2025 14:04:12 +0000 (10:04 -0400)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 12 May 2025 17:43:43 +0000 (10:43 -0700)
commitc5bcc8c781277eeffe84fe75144af1da76b7ec3e
tree9b46d51f3426d80ad98d38d71bb3f6b3e4ab8d47
parent7220eabff8cb4af3b93cd021aa853b9f5df2923f
selftests/bpf: test_verifier verbose causes erroneous failures

When running test_verifier with the -v flag and a test with
`expected_ret==VERBOSE_ACCEPT`, the opts.log_level is unintentionally
overwritten because the verbose flag takes precedence. This leads to
a mismatch in the expected and actual contents of bpf_vlog, causing
tests to fail incorrectly.

Reorder the conditional logic that sets opts.log_level to preserve
the expected log level and prevent it from being overridden by -v.

Signed-off-by: Gregory Bell <grbell@redhat.com>
Link: https://lore.kernel.org/r/182bf00474f817c99f968a9edb119882f62be0f8.1747058195.git.grbell@redhat.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/test_verifier.c