Revert "serial: core: only stop transmit when HW fifo is empty"
authorDoug Brown <doug@schmorgal.com>
Thu, 6 Jun 2024 19:56:31 +0000 (12:56 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Jun 2024 14:14:33 +0000 (16:14 +0200)
commitc5603e2a621dac10c5e21cc430848ebcfa6c7e01
treee71b62b85142b2c606ed1388b558898363770d23
parenta81dbd0463eca317eee44985a66aa6cc2ce5c101
Revert "serial: core: only stop transmit when HW fifo is empty"

This reverts commit 7bfb915a597a301abb892f620fe5c283a9fdbd77.

This commit broke pxa and omap-serial, because it inhibited them from
calling stop_tx() if their TX FIFOs weren't completely empty. This
resulted in these two drivers hanging during transmits because the TX
interrupt would stay enabled, and a new TX interrupt would never fire.

Cc: stable@vger.kernel.org
Fixes: 7bfb915a597a ("serial: core: only stop transmit when HW fifo is empty")
Signed-off-by: Doug Brown <doug@schmorgal.com>
Link: https://lore.kernel.org/r/20240606195632.173255-2-doug@schmorgal.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/serial_core.h