net/mlx5: SD, Do not query MPIR register if no sd_group
authorTariq Toukan <tariqt@nvidia.com>
Thu, 8 Aug 2024 14:41:02 +0000 (17:41 +0300)
committerJakub Kicinski <kuba@kernel.org>
Sat, 10 Aug 2024 05:16:46 +0000 (22:16 -0700)
commitc31fe2b5095d8c84562ce90db07600f7e9f318df
tree5397f1da55c774325b6d81cadf621f782f83b743
parentd2438c16a6347f811ab0249330ee9e54fa3db6b0
net/mlx5: SD, Do not query MPIR register if no sd_group

Unconditionally calling the MPIR query on BF separate mode yields the FW
syndrome below [1]. Do not call it unless admin clearly specified the SD
group, i.e. expressing the intention of using the multi-PF netdev
feature.

This fix covers cases not covered in
commit fca3b4791850 ("net/mlx5: Do not query MPIR on embedded CPU function").

[1]
mlx5_cmd_out_err:808:(pid 8267): ACCESS_REG(0x805) op_mod(0x1) failed,
status bad system state(0x4), syndrome (0x685f19), err(-5)

Fixes: 678eb448055a ("net/mlx5: SD, Implement basic query and instantiation")
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Gal Pressman <gal@nvidia.com>
Link: https://patch.msgid.link/20240808144107.2095424-2-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c