tools lib traceevent: Fix string handling in heterogeneous arch environments
authorKapileshwar Singh <kapileshwar.singh@arm.com>
Tue, 22 Sep 2015 13:22:03 +0000 (14:22 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 22 Sep 2015 14:57:04 +0000 (11:57 -0300)
commitc2e4b24ff848bb180f9b9cd873a38327cd219ad2
tree8877a60171d806ce1d83d86d319b9db9f731bcb4
parent381c02f6d8ccad8ed574630f879c40fb59715124
tools lib traceevent: Fix string handling in heterogeneous arch environments

When a trace recorded on a 32-bit device is processed with a 64-bit
binary, the higher 32-bits of the address need to ignored.

The lack of this results in the output of the 64-bit pointer
value to the trace as the 32-bit address lookup fails in find_printk().

Before:

  burn-1778  [003]   548.600305: bputs:   0xc0046db2s: 2cec5c058d98c

After:

  burn-1778  [003]   548.600305: bputs:   0xc0046db2s: RT throttling activated

The problem occurs in PRINT_FIELD when the field is recognized as a
pointer to a string (of the type const char *)

Heterogeneous architectures cases below can arise and should be handled:

* Traces recorded using 32-bit addresses processed on a 64-bit machine
* Traces recorded using 64-bit addresses processed on a 32-bit machine

Reported-by: Juri Lelli <juri.lelli@arm.com>
Signed-off-by: Kapileshwar Singh <kapileshwar.singh@arm.com>
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Javi Merino <javi.merino@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1442928123-13824-1-git-send-email-kapileshwar.singh@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/lib/traceevent/event-parse.c