watchdog: diag288_wdt: get rid of register asm
authorAlexander Egorenkov <egorenar@linux.ibm.com>
Fri, 3 Feb 2023 07:39:54 +0000 (08:39 +0100)
committerHeiko Carstens <hca@linux.ibm.com>
Mon, 6 Feb 2023 14:14:08 +0000 (15:14 +0100)
commitc24def73a2863a8292693ab49a83303213ef3f23
treee4c5812b4615df899d18fdb51602f0f974949164
parent83089c8f502e87ca74dd5f8cd460536c43318fef
watchdog: diag288_wdt: get rid of register asm

Using register asm statements has been proven to be very error prone,
especially when using code instrumentation where gcc may add function
calls, which clobbers register contents in an unexpected way.

Therefore, get rid of register asm statements in watchdog code, and make
sure this bug class cannot happen.

Moreover, remove the register r1 from the clobber list because this
register is not changed by DIAG 288.

Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230203073958.1585738-2-egorenar@linux.ibm.com
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
drivers/watchdog/diag288_wdt.c