bpf: fix visit_insn()'s detection of BPF_FUNC_timer_set_callback helper
authorAndrii Nakryiko <andrii@kernel.org>
Thu, 2 Mar 2023 23:50:05 +0000 (15:50 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Sat, 4 Mar 2023 19:14:32 +0000 (11:14 -0800)
commitc1ee85a9806a720aa054f68fe7f9c79418f36c2b
tree41e29a5dfd316afa82aeef5ac69a035f5852d051
parent653ae3a874aca6764a4c1f5a8bf1b072ade0d6f4
bpf: fix visit_insn()'s detection of BPF_FUNC_timer_set_callback helper

It's not correct to assume that any BPF_CALL instruction is a helper
call. Fix visit_insn()'s detection of bpf_timer_set_callback() helper by
also checking insn->code == 0. For kfuncs insn->code would be set to
BPF_PSEUDO_KFUNC_CALL, and for subprog calls it will be BPF_PSEUDO_CALL.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/r/20230302235015.2044271-8-andrii@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/verifier.c