team: Fix use-after-free when an option instance allocation fails
authorFlorent Revest <revest@chromium.org>
Wed, 6 Dec 2023 12:37:18 +0000 (13:37 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 8 Dec 2023 18:45:49 +0000 (10:45 -0800)
commitc12296bbecc488623b7d1932080e394d08f3226b
tree64a80a621d3cb96a366a2a5dff42e9a7121a205d
parentbd4a816752bab609dd6d65ae021387beb9e2ddbd
team: Fix use-after-free when an option instance allocation fails

In __team_options_register, team_options are allocated and appended to
the team's option_list.
If one option instance allocation fails, the "inst_rollback" cleanup
path frees the previously allocated options but doesn't remove them from
the team's option_list.
This leaves dangling pointers that can be dereferenced later by other
parts of the team driver that iterate over options.

This patch fixes the cleanup path to remove the dangling pointers from
the list.

As far as I can tell, this uaf doesn't have much security implications
since it would be fairly hard to exploit (an attacker would need to make
the allocation of that specific small object fail) but it's still nice
to fix.

Cc: stable@vger.kernel.org
Fixes: 80f7c6683fe0 ("team: add support for per-port options")
Signed-off-by: Florent Revest <revest@chromium.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://lore.kernel.org/r/20231206123719.1963153-1-revest@chromium.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/team/team.c