ice: fix E825-C TSPLL register definitions
authorJacob Keller <jacob.e.keller@intel.com>
Thu, 1 May 2025 22:54:14 +0000 (15:54 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 18 Jun 2025 15:59:23 +0000 (08:59 -0700)
commitbf12bc439407e27f4dcfbbb40edec6278e1ad13a
treef8e68f3c176c3401a6d5c9303adf3f1c57a3b3f7
parent1ff7a6c5d3f5d84a5036ef98bf8790de2ebd9360
ice: fix E825-C TSPLL register definitions

The E825-C hardware has a slightly different register layout for register
19 of the Clock Generation Unit and TSPLL. The fbdiv_intgr value can be 10
bits wide.

Additionally, most of the fields that were in register 24 are made
available in register 23 instead. The programming logic already has a
corrected definition for register 23, but it incorrectly still used the
8-bit definition of fbdiv_intgr. This results in truncating some of the
values of fbdiv_intgr, including the value used for the 156.25MHz signal.

The driver only used register 24 to obtain the enable status, which we
should read from register 23. This results in an incorrect output for the
log messages, but does not change any functionality besides
disabled-by-default dynamic debug messages.

Fix the register definitions, and adjust the code to properly reflect the
enable/disable status in the log messages.

Co-developed-by: Karol Kolacinski <karol.kolacinski@intel.com>
Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_common.h
drivers/net/ethernet/intel/ice/ice_tspll.c