9p/trans_fd: Fix concurrency del of req_list in p9_fd_cancelled/p9_read_work
authorWang Hai <wanghai38@huawei.com>
Fri, 12 Jun 2020 09:08:33 +0000 (17:08 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Aug 2020 07:58:36 +0000 (09:58 +0200)
commitbeab956bdc0add5371e52d29c0d6f840c1f55609
tree61158d8822d6cfffda43c7f7ab99fa8b1c9cb178
parentfde502224ed421b7e81b3a332b81d55913c1db0b
9p/trans_fd: Fix concurrency del of req_list in p9_fd_cancelled/p9_read_work

commit 74d6a5d5662975aed7f25952f62efbb6f6dadd29 upstream.

p9_read_work and p9_fd_cancelled may be called concurrently.
In some cases, req->req_list may be deleted by both p9_read_work
and p9_fd_cancelled.

We can fix it by ignoring replies associated with a cancelled
request and ignoring cancelled request if message has been received
before lock.

Link: http://lkml.kernel.org/r/20200612090833.36149-1-wanghai38@huawei.com
Fixes: 60ff779c4abb ("9p: client: remove unused code and any reference to "cancelled" function")
Cc: <stable@vger.kernel.org> # v3.12+
Reported-by: syzbot+77a25acfa0382e06ab23@syzkaller.appspotmail.com
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/9p/trans_fd.c