ext4: use memtostr_pad() for s_volume_name
authorKees Cook <keescook@chromium.org>
Thu, 23 May 2024 22:54:12 +0000 (15:54 -0700)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 5 Jul 2024 17:14:51 +0000 (13:14 -0400)
commitbe27cd64461c45a6088a91a04eba5cd44e1767ef
tree4176a9e7543490df24787d87297e2a90d2f6a9ac
parent7c73ddb7589fb8ddb1136b6306dfb72089c81511
ext4: use memtostr_pad() for s_volume_name

As with the other strings in struct ext4_super_block, s_volume_name is
not NUL terminated. The other strings were marked in commit 072ebb3bffe6
("ext4: add nonstring annotations to ext4.h"). Using strscpy() isn't
the right replacement for strncpy(); it should use memtostr_pad()
instead.

Reported-by: syzbot+50835f73143cc2905b9e@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/00000000000019f4c00619192c05@google.com/
Fixes: 744a56389f73 ("ext4: replace deprecated strncpy with alternatives")
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://patch.msgid.link/20240523225408.work.904-kees@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/ext4.h
fs/ext4/ioctl.c