thermal: sysfs: Rework the handling of trip point updates
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 5 Dec 2023 12:24:08 +0000 (13:24 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 6 Dec 2023 20:29:52 +0000 (21:29 +0100)
commitbe0a3600aa1ebe9d23243c91d41ab1a2d5091a9b
tree68789a51673d9faa01882eccbbdda86891fed228
parent59730241647287c0ab64bf0bc7449308392b7ea4
thermal: sysfs: Rework the handling of trip point updates

Both trip_point_temp_store() and trip_point_hyst_store() use
thermal_zone_set_trip() to update a given trip point, but none of them
actually needs to change more than one field in struct thermal_trip
representing it.  However, each of them effectively calls
__thermal_zone_get_trip() twice in a row for the same trip index value,
once directly and once via thermal_zone_set_trip(), which is not
particularly efficient, and the way in which thermal_zone_set_trip()
carries out the update is not particularly straightforward.

Moreover, input processing need not be done under the thermal zone lock
in any of these functions.

Rework trip_point_temp_store() and trip_point_hyst_store() to address
the above, move the part of thermal_zone_set_trip() that is still
useful to a new function called thermal_zone_trip_updated() and drop
the rest of it.

While at it, make trip_point_hyst_store() reject negative hysteresis
values.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/thermal/thermal_core.h
drivers/thermal/thermal_sysfs.c
drivers/thermal/thermal_trip.c
include/linux/thermal.h