gfs2: Fix slab-use-after-free in gfs2_qd_dealloc
authorJuntong Deng <juntong.deng@outlook.com>
Sun, 29 Oct 2023 21:10:06 +0000 (05:10 +0800)
committerAndreas Gruenbacher <agruenba@redhat.com>
Mon, 6 Nov 2023 00:51:26 +0000 (01:51 +0100)
commitbdcb8aa434c6d36b5c215d02a9ef07551be25a37
tree1154c109e3ce89a69219fc439f53ec56158f4c9e
parent074d7306a4fe22fcac0b53f699f92757ab1cee99
gfs2: Fix slab-use-after-free in gfs2_qd_dealloc

In gfs2_put_super(), whether withdrawn or not, the quota should
be cleaned up by gfs2_quota_cleanup().

Otherwise, struct gfs2_sbd will be freed before gfs2_qd_dealloc (rcu
callback) has run for all gfs2_quota_data objects, resulting in
use-after-free.

Also, gfs2_destroy_threads() and gfs2_quota_cleanup() is already called
by gfs2_make_fs_ro(), so in gfs2_put_super(), after calling
gfs2_make_fs_ro(), there is no need to call them again.

Reported-by: syzbot+29c47e9e51895928698c@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=29c47e9e51895928698c
Signed-off-by: Juntong Deng <juntong.deng@outlook.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/super.c