XFS: fix zoned gc threshold math for 32-bit arches
authorCarlos Maiolino <cem@kernel.org>
Tue, 22 Apr 2025 12:54:54 +0000 (14:54 +0200)
committerCarlos Maiolino <cem@kernel.org>
Tue, 22 Apr 2025 14:03:14 +0000 (16:03 +0200)
commitbd7c19331913b955a7823e6315ca16bbcc65aeff
tree2b7f1d1f724161ac2233ea25d7d3159cfba8ed42
parentc7b67ddc3c999aa2f8d77be7ef1913298fe78f0e
XFS: fix zoned gc threshold math for 32-bit arches

xfs_zoned_need_gc makes use of mult_frac() to calculate the threshold
for triggering the zoned garbage collector, but, turns out mult_frac()
doesn't properly work with 64-bit data types and this caused build
failures on some 32-bit architectures.

Fix this by essentially open coding mult_frac() in a 64-bit friendly
way.

Notice we don't need to bother with counters underflow here because
xfs_estimate_freecounter() will always return a positive value, as it
leverages percpu_counter_read_positive to read such counters.

Fixes: 845abeb1f06a ("xfs: add tunable threshold parameter for triggering zone GC")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504181233.F7D9Atra-lkp@intel.com/
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hans Holmberg <hans.holmberg@wdc.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_zone_gc.c