xen/pcpu: fix possible memory leak in register_pcpu()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 10 Nov 2022 15:24:41 +0000 (23:24 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Nov 2022 16:45:47 +0000 (17:45 +0100)
commitbb9924a6edd9d4a9ef83a5f337af60f8a7a68f98
tree7cca5a330472e417afaf08a4dc7c2087887d1d24
parentd6a561bd4c53c5fc8cade48a555d3dc6acfb2c5b
xen/pcpu: fix possible memory leak in register_pcpu()

[ Upstream commit da36a2a76b01b210ffaa55cdc2c99bc8783697c5 ]

In device_add(), dev_set_name() is called to allocate name, if it returns
error, the name need be freed. As comment of device_register() says, it
should use put_device() to give up the reference in the error path. So fix
this by calling put_device(), then the name can be freed in kobject_cleanup().

Fixes: f65c9bb3fb72 ("xen/pcpu: Xen physical cpus online/offline sys interface")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20221110152441.401630-1-yangyingliang@huawei.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/xen/pcpu.c