perf arm-spe: Use old behavior when opening old SPE files
authorJames Clark <james.clark@linaro.org>
Tue, 29 Oct 2024 14:37:33 +0000 (14:37 +0000)
committerNamhyung Kim <namhyung@kernel.org>
Thu, 31 Oct 2024 06:50:47 +0000 (23:50 -0700)
commitba993e5ada1ddce7a71140dc85ef65bc2cd981bc
tree137159eebe2a1ceee7688aa4409a8f612b46972e
parent064d569e20e82c065b1dec9d20c29c7087bb1a00
perf arm-spe: Use old behavior when opening old SPE files

Since the linked commit, we stopped interpreting data source if the
perf.data file doesn't have the new metadata version. This means that
perf c2c will show no samples in this case.

Keep the old behavior so old files can be opened, but also still show
the new warning that updating might improve the decoding.

Also re-write the warning to be more concise and specific to a user.

Fixes: ba5e7169e548 ("perf arm-spe: Use metadata to decide the data source feature")
Signed-off-by: James Clark <james.clark@linaro.org>
Reviewed-by: Leo Yan <leo.yan@arm.com>
Cc: Julio.Suarez@arm.com
Cc: Kiel.Friedt@arm.com
Cc: Ryan.Roberts@arm.com
Cc: Will Deacon <will@kernel.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Besar Wicaksono <bwicaksono@nvidia.com>
Cc: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20241029143734.291638-1-james.clark@linaro.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/arm-spe.c