net: netdevsim: fix nsim_pp_hold_write()
authorEric Dumazet <edumazet@google.com>
Mon, 16 Dec 2024 08:37:03 +0000 (08:37 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Dec 2024 01:46:17 +0000 (17:46 -0800)
commitb9b8301d369b4c876de5255dbf067b19ba88ac71
treea3c2ea4ce5b730c203b9a0e78f2f2ae28299a0e5
parent7ed2d91588779f0a2b27fd502ce2aaf1fab9b3ca
net: netdevsim: fix nsim_pp_hold_write()

nsim_pp_hold_write() has two problems:

1) It may return with rtnl held, as found by syzbot.

2) Its return value does not propagate an error if any.

Fixes: 1580cbcbfe77 ("net: netdevsim: add some fake page pool use")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241216083703.1859921-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/netdevsim/netdev.c