drm/msm/a6xx: Fix up QMP handling
authorKonrad Dybcio <konrad.dybcio@linaro.org>
Fri, 13 Oct 2023 23:07:46 +0000 (01:07 +0200)
committerRob Clark <robdclark@chromium.org>
Mon, 16 Oct 2023 14:29:42 +0000 (07:29 -0700)
commitb9986846189cea87a9d93052cfab462c9e74f447
treed2346831c35ecaabc71c58e86b5774ac5e325d0a
parent5e05be78264594634860087953649487f486ffcc
drm/msm/a6xx: Fix up QMP handling

The commit referenced in the Fixes tag had a couple problems (as
pointed out by Dan):

- qmp_put was never called, resulting in refcnt leaks
- failling to acquire the QMP mailbox on A7xx would not undo the probe
  function properly
- the qmp_put call present in the code was unreachable

Fix all of these issues.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: 88a0997f2f94 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/562761/
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/adreno/a6xx_gmu.c