xirc2ps_cs: fix register access when enabling FullDuplex
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Wed, 27 Aug 2025 19:26:43 +0000 (12:26 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 30 Aug 2025 02:05:11 +0000 (19:05 -0700)
commitb79e498080b170fd94fc83bca2471f450811549b
treec5416133c7b4702c2f3ef3d8d6a98a6a1d5d5e0b
parent9f74c0ea9b26d1505d55b61e36b1623dd347e1d1
xirc2ps_cs: fix register access when enabling FullDuplex

The current code incorrectly passes (XIRCREG1_ECR | FullDuplex) as
the register address to GetByte(), instead of fetching the register
value and OR-ing it with FullDuplex. This results in an invalid
register access.

Fix it by reading XIRCREG1_ECR first, then or-ing with FullDuplex
before writing it back.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250827192645.658496-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/xircom/xirc2ps_cs.c