fhandle: do_handle_open() should get FD with user flags
authorThomas Bertschinger <tahbertschinger@gmail.com>
Thu, 14 Aug 2025 23:54:28 +0000 (17:54 -0600)
committerChristian Brauner <brauner@kernel.org>
Fri, 15 Aug 2025 13:46:57 +0000 (15:46 +0200)
commitb5ca88927e353185b3d9ac4362d33e5aeb25771f
tree8963af05685424175f311b1ca0aee10cab214032
parent6d3c3ca4c77e93660cce5819bf707f75df03e0c8
fhandle: do_handle_open() should get FD with user flags

In f07c7cc4684a, do_handle_open() was switched to use the automatic
cleanup method for getting a FD. In that change it was also switched
to pass O_CLOEXEC unconditionally to get_unused_fd_flags() instead
of passing the user-specified flags.

I don't see anything in that commit description that indicates this was
intentional, so I am assuming it was an oversight.

With this fix, the FD will again be opened with, or without, O_CLOEXEC
according to what the user requested.

Fixes: f07c7cc4684a ("fhandle: simplify error handling")
Signed-off-by: Thomas Bertschinger <tahbertschinger@gmail.com>
Link: https://lore.kernel.org/20250814235431.995876-4-tahbertschinger@gmail.com
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/fhandle.c