mm/damon/sysfs: check error from damon_sysfs_update_target()
authorSeongJae Park <sj@kernel.org>
Mon, 6 Nov 2023 23:34:06 +0000 (23:34 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 15 Nov 2023 23:30:09 +0000 (15:30 -0800)
commitb4936b544b08ed44949055b92bd25f77759ebafc
treed2a1d6b218dee8d6f083c666cf4e34b0cf9ac9c0
parenta48d5bdc877b85201e42cef9c2fdf5378164c23a
mm/damon/sysfs: check error from damon_sysfs_update_target()

Patch series "mm/damon/sysfs: fix unhandled return values".

Some of DAMON sysfs interface code is not handling return values from some
functions.  As a result, confusing user input handling or NULL-dereference
is possible.  Check those properly.

This patch (of 3):

damon_sysfs_update_target() returns error code for failures, but its
caller, damon_sysfs_set_targets() is ignoring that.  The update function
seems making no critical change in case of such failures, but the behavior
will look like DAMON sysfs is silently ignoring or only partially
accepting the user input.  Fix it.

Link: https://lkml.kernel.org/r/20231106233408.51159-1-sj@kernel.org
Link: https://lkml.kernel.org/r/20231106233408.51159-2-sj@kernel.org
Fixes: 19467a950b49 ("mm/damon/sysfs: remove requested targets when online-commit inputs")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org> [5.19+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/sysfs.c